Add models as first supported 'asset' type #10045
Open
+8,189
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for input validation
…ry instead of N+1
…ate endpoint for test suite.
[Assets] Initial implementation
…g yet uses the hashes
|
just fyi: CI fails on macOS due to missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With most of the networking and db code done by @bigcat88 , this PR:
Models are the only thing that will be treated as 'assets' currently. Goal is for the hash + tags to be used in a new Asset widget that will allow workflows to embed the hash of models, so that it will be easy to share workflows and know exactly what model is needed.
As the first step, while this PR does introduce blake3 hashing, it does not actually make use of it since the frontend elements are not ready - so no hashing enabled just yet. When enabled in the future, it will hash just the first time a model is loaded.
ETA: will review with @comfyanonymous on Saturday 9/27 to determine if any changes need to be made to this initial version.